Skip to content

epic: remove proven orphans and obsolete allowances #192

Closed

Description

@bravew

Completion status — 2026-10-15

Completed and merged into main via #282, commit c7f8ac2e8e8f20b4cf89cc1189dda041394e50d9. The observable-result checklist below is updated to reflect the delivered scope and recorded decisions. Final integrated main aaca138d7c3773be662941b4081c8d97ea40019c passed post-merge CI. Final local verification passed pnpm validate, 5,895 frontend/API tests, and five policy-record tests. Browser E2E was skipped.


Epic branch: epic/192-dead-code. Plan checkpoint 5 of 7.

Why

Dead code accumulated across many iterations. The review's unused-file scan was not trustworthy (Knip exited 2 and manifest-loaded design-system data was a false positive), so nothing here is deleted from a generic report. Each batch proves its former entry graph first and removes the island with its exclusive tests, exports, and locale keys in one PR.

Evidence is in 01-findings.md. The sequencing is in 02-development-plan.md. The lessons behind it are in LESSONS.md and 03-lessons-and-contributors.md.

Observable result

  • Each deleted island has a recorded former entry graph and no dangling runtime, locale, or config reference.
  • The nine allowlist entries whose files already fit the 350-line default are removed.
  • Dependency removals are proven unused across CSS, configs, generated builds, and workspace manifests, and the lockfile changes only for the removed packages.
  • The live V1 task route, both settings shells, channels, and extension APIs are untouched until their contracts are decided.

Sub-issues

Sub-issues without a blocker can run in parallel, each in its own worktree: #217, #218, #221.

How this epic is worked

  1. The maintainer creates epic/192-dead-code from main and pushes it. Nobody commits to it directly.
  2. Each sub-issue is implemented by one agent in its own git worktree on issue/<n>-<slug>, opened as a PR whose base is epic/192-dead-code and whose body contains Closes #<sub-issue>.
  3. A merged sub-issue PR closes its issue through .github/workflows/epic-close-issues.yml. Sub-issues merge by squash, one commit each.
  4. When every sub-issue above is closed, open one epic PR from epic/192-dead-code into main with Closes #192. Run pnpm validate, pnpm test:fast (naming the known resolve.test.ts failure until it is fixed), and the surface checks for this epic on the final head, and write that head sha in the PR.
  5. The maintainer reviews and merges the epic PR. No sub-issue PR targets main.

Shared files that two streams must not edit at once are package.json, pnpm-lock.yaml, locale modules, component-size-allowlist.json, http-daemon.ts, video-edit-server.ts, and the shared video IR schemas. Each sub-issue names the files it owns and what it is blocked by. If you need a file another open sub-issue owns, comment on both issues and wait.

Suggested merge order into main across epics is E1 first, so later epic PRs run the repaired gate, then the rest by priority. Rebase an epic branch onto main before its final PR.

Activity

  1. bravew commented on Oct 15, 2026

    @bravew
    OwnerAuthor

    Completed in #282 and merged into main as c7f8ac2e8e8f20b4cf89cc1189dda041394e50d9. All seven epic changes are integrated at aaca138d7c3773be662941b4081c8d97ea40019c, with successful post-merge CI: https://github.com/bravew/Neumar/actions/runs/38678829734. Updated the completion checklist and status above. Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions