Skip to content

Fix comments in *.pest files #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sportfloh wants to merge 1 commit into from
Closed

Fix comments in *.pest files #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/zones/preprocessor.pest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
/// DNS Zone file parsing (pre-processor)
///
/// Due to the rules around braces we preprocess the file,
/// and write out something easier to parse.
//! DNS Zone file parsing (pre-processor)

// Due to the rules around braces we preprocess the file,
// and write out something easier to parse.

comment = { ";" ~ (!NEWLINE ~ ANY)* }
open = { "(" }
Expand Down
26 changes: 13 additions & 13 deletions src/zones/zones.pest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
/// DNS Zone file parsing
///
/// Format is defined in rfc1035 Section 5, extended rfc2308 Section 4.
///
/// <domain-name><rr> [<comment>]
/// <blank><rr> [<comment>]
/// ```
///
/// <rr> contents take one of the following forms:
/// ```text
/// [<TTL>] [<class>] <type> <RDATA>
/// [<class>] [<TTL>] <type> <RDATA>
/// ```
//! DNS Zone file parsing

// Format is defined in rfc1035 Section 5, extended rfc2308 Section 4.

@bramp bramp Sep 2, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a //! Comment as well? I feel this top block is all meant to be a module comment

//
// <domain-name><rr> [<comment>]
// <blank><rr> [<comment>]
// ```
//
// <rr> contents take one of the following forms:
// ```text
// [<TTL>] [<class>] <type> <RDATA>
// [<class>] [<TTL>] <type> <RDATA>
// ```

// We use explict WHITESPACE to ensure there is whitespace between matching tokens
// as opposed to optional WHITESPACE.
Expand Down