Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if bin2ml extraction of function-separated data files (e.g. bytes) was be cancelled/aborted half way, restarting it would mean extracting all function data from the beginning, including the files that were already successfully extracted.
With this PR, bin2ml identifies a partial directory, scans it for pre-existing data files, and starts extracting from the last successful function data file. The last successful file is overwritten with new data as it is the most likely to be incomplete/corrupted. Furthermore, if the option
--retry-abortedwas set, it retries extracting functions for which anerror.logfile exists.