Repository navigation
fix(snapshot): accept trailing commas in unsupported macro - #5
Merged
ltstriker merged 1 commit intoOct 29, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
lfld287
marked this pull request as ready for review
October 29, 2026 03:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS ARM64, snapshot-host-check fails because three unsupported snapshot macro invocations include trailing commas. Allow an optional trailing comma in the macro matcher so both invocation forms compile. Exported signatures and -ENOTSUP behavior are unchanged.
Validation on macOS ARM64:
make snapshot-host-check SNAPSHOT_CARGO_FLAGS='--offline --locked'passed for default features andblk,net, with one snapshot test passing in each configuration, using the existing placeholder init without starting a guest.rustfmt --check --edition 2021 src/libkrun/src/snapshot/descriptor.rsandgit diff --checkpassed.The change is limited to one line in one file. Existing unused-import warnings remain. BoxLite CLI integration tests were not run.