Skip to content

fix(snapshot): accept trailing commas in unsupported macro - #5

Merged
ltstriker merged 1 commit into
boxlite-ai:x_featuresfrom
lfld287:fix/macos-snapshot-trailing-comma
Oct 29, 2026
Merged

ltstriker merged 1 commit into
boxlite-ai:x_featuresfrom
lfld287:fix/macos-snapshot-trailing-comma

Conversation

@lfld287

@lfld287 lfld287 commented Oct 29, 2026

Copy link
Copy Markdown

On macOS ARM64, snapshot-host-check fails because three unsupported snapshot macro invocations include trailing commas. Allow an optional trailing comma in the macro matcher so both invocation forms compile. Exported signatures and -ENOTSUP behavior are unchanged.

Validation on macOS ARM64:

  • make snapshot-host-check SNAPSHOT_CARGO_FLAGS='--offline --locked' passed for default features and blk,net, with one snapshot test passing in each configuration, using the existing placeholder init without starting a guest.
  • rustfmt --check --edition 2021 src/libkrun/src/snapshot/descriptor.rs and git diff --check passed.

The change is limited to one line in one file. Existing unused-import warnings remain. BoxLite CLI integration tests were not run.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 9fe0557a-1860-41cc-b9b5-2d25c79628d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lfld287
lfld287 marked this pull request as ready for review October 29, 2026 03:41

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@ltstriker
ltstriker merged commit 2294eea into boxlite-ai:x_features Oct 29, 2026
1 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants