Add missing non-const BoundaryRegionIterBase::prev overload - #3484
Draft
ZedThree wants to merge 1 commit into
Draft
Add missing non-const BoundaryRegionIterBase::prev overload#3484ZedThree wants to merge 1 commit into
BoundaryRegionIterBase::prev overload#3484ZedThree wants to merge 1 commit into
Conversation
Missing non-const ref overload meant it was not possible to assign to `point.prev(f)`
ZedThree
marked this pull request as draft
August 28, 2026 17:00
Member
Author
|
Actually there's at least one other function missing and some functions duplicated between the base and derived classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing non-const ref overload meant it was not possible to assign to
point.prev(f)@dschwoerer Please can this go into the Hermes-3 BOUT++ update PR?