Skip to content

Honor bndry_flux for FCI #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschwoerer wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Honor bndry_flux for FCI #3483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7537c1
Honor bndry_flux for FCI for Div_par_K_Grad_par_mod
dschwoerer Aug 28, 2026
1a71822
Honor bndry_flux for FCI for Div_par_K_Grad_par
dschwoerer Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/mesh/difops.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include <bout/solver.hxx>
#include <bout/unused.hxx>
#include <bout/utils.hxx>
#include <bout/yboundary_regions.hxx>

#include <cmath>
#include <limits>
Expand Down Expand Up @@ -386,23 +387,32 @@ Field3D Div_par_K_Grad_par_mod_impl(const Field3DParallel& Kin,
Field3D result{zeroFrom(fin)};
flow_ylow = zeroFrom(fin);

const auto yboundary = coord->getYBoundary();

BOUT_FOR(i, result.getRegion("RGN_NOBNDRY")) {
const auto iyp = i.yp();
const auto iym = i.ym();

// Upper cell edge
const BoutReal c_up = 0.5 * (Kin[i] + K_up[iyp]); // K at the upper boundary
const BoutReal gradient_up =
(f_up[iyp] - fin[i]) / (coord->dy()[i] * sqrt(coord->g_22_yhigh()[i]));
BoutReal flux_up = 0;
if (bndry_flux or not yboundary.contains<+1>(i)) {
const BoutReal c_up = 0.5 * (Kin[i] + K_up[iyp]); // K at the upper boundary

const BoutReal gradient_up =
(f_up[iyp] - fin[i]) / (coord->dy()[i] * sqrt(coord->g_22_yhigh()[i]));

const BoutReal flux_up = c_up * gradient_up * coord->cell_area_yhigh()[i];
flux_up = c_up * gradient_up * coord->cell_area_yhigh()[i];
}

// Lower cell edge
const BoutReal c_down = 0.5 * (Kin[i] + K_down[iym]); // K at the lower boundary
const BoutReal gradient_down =
(fin[i] - f_down[iym]) / (coord->dy()[i] * sqrt(coord->g_22_ylow()[i]));
BoutReal flux_down = 0;
if (bndry_flux or not yboundary.contains<-1>(i)) {
const BoutReal c_down = 0.5 * (Kin[i] + K_down[iym]); // K at the lower boundary
const BoutReal gradient_down =
(fin[i] - f_down[iym]) / (coord->dy()[i] * sqrt(coord->g_22_ylow()[i]));

const BoutReal flux_down = c_down * gradient_down * coord->cell_area_ylow()[i];
flux_down = c_down * gradient_down * coord->cell_area_ylow()[i];
}

// Add the fluxes
result[i] = (flux_up - flux_down) / (coord->cell_volume()[i]);
Expand Down
16 changes: 12 additions & 4 deletions src/mesh/fv_ops.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "bout/msg_stack.hxx"
#include "bout/region.hxx"
#include "bout/utils.hxx"
#include <bout/yboundary_regions.hxx>

namespace {
template <class T>
Expand Down Expand Up @@ -211,8 +212,12 @@ Field3D Div_par_K_Grad_par(const Field3D& Kin, const Field3D& fin, bool bndry_fl
const auto iyp = i.yp();
const auto iym = i.ym();

if (bndry_flux || mesh->periodicY(i.x()) || !mesh->lastY(i.x())
|| (i.y() != mesh->yend)) {
const auto yboundary = coord->getYBoundary();

if (bndry_flux
|| (not K.isFci()
and (mesh->periodicY(i.x()) || !mesh->lastY(i.x()) || (i.y() != mesh->yend)))
or (K.isFci() and yboundary.contains<+1>(i))) {

const BoutReal c = 0.5 * (K[i] + Kup[iyp]); // K at the upper boundary
const BoutReal J = 0.5 * (coord->J()[i] + coord->J()[iyp]); // Jacobian at boundary
Expand All @@ -227,8 +232,11 @@ Field3D Div_par_K_Grad_par(const Field3D& Kin, const Field3D& fin, bool bndry_fl
}

// Calculate flux at lower surface
if (bndry_flux || mesh->periodicY(i.x()) || !mesh->firstY(i.x())
|| (i.y() != mesh->ystart)) {
if (bndry_flux
|| (not K.isFci()
and (mesh->periodicY(i.x()) || !mesh->firstY(i.x())
|| (i.y() != mesh->ystart)))
or (K.isFci() and yboundary.contains<-1>(i))) {
const BoutReal c = 0.5 * (K[i] + Kdown[iym]); // K at the lower boundary
const BoutReal J = 0.5 * (coord->J()[i] + coord->J()[iym]); // Jacobian at boundary

Expand Down
Loading