Stage a four-byte part in the S3 stage cases, not a 5 MiB one - #9
Closed
tiptenbrink wants to merge 1 commit into
Closed
tiptenbrink wants to merge 1 commit into
tiptenbrink wants to merge 1 commit into
Conversation
S3 takes a part of any size until a completion names it before another part. Each stage case carried the 5 MiB part twice, which made operations.json 34 MB; it is now 6 MB. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Collaborator
Author
|
Folded into #8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operations/s3/stageandoperations/s3-express/stageuploaded a 5 MiB part, carried twice as base64 in each case: in the call and in the request check. They made up 28 of the 34 MB ofcases/operations.json.cases/operations.jsonis now 6 MB.Test plan
object-tests validate cases/operations.jsonpasses (916 cases).