Cover more of S3 listing, and make its cases steer clients better - #5
Merged
Merged
Conversation
New S3 and Express listing cases grade entry properties, fetch-owner, start-after, page walks, 1,001 keys, a truncated page without a token, special characters in prefixes and grouping at another delimiter. The grader exposes raw_query and a check's because, so the S3 profiles fail a raw + in a query with the reason; S3 XML fixtures carry the declaration and " ETags, and listing purposes state their rules. The core S3 listing cases accept encoding-type=url, as the operation cases do. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the S3 listing cases say enough that a client can reach a correct and good implementation from the grading alone. Every S3 path is verified live against S3 and S3 Express.
New cases
list-entry-properties: an entry'slast_modified(RFC 3339, UTC, whole seconds) andstorage_class, with one object inSTANDARD_IA.list-fetch-owner:owner_idwithfetch-owner=true. S3 honours only the literaltrue; the AWS C++ SDK sends1and fails.list-start-afterandlist-start-after-delimited. On a directory bucket,start-afteris answered 501NotSupported.list-all-pages, a walk over three pages, andlist-over-1000, 1,001 keys at the default page size.list-truncated-without-token: a truncated page without a token must be reported as an error. It is offline only.list-prefix-special-characters: a prefix and a common prefix holding a space,+,&,=,%andé.list-bucket-missingon Express: CreateSession's 404NoSuchBucket, and nothing more.list-other-delimiternow groups keys at-. Before, no key held a-, so a client that dropped the delimiter passed.Grading changes
raw_query, the query as sent, and a check may carrybecause, which a failure reports.+in the query. S3 reads it as a space, so a continuation token or upload ID holding+breaks. The failure says to send%2B, or%20for a space.", as S3 sends them.s3/list-*cases acceptencoding-type=url, as the operation cases do.list-encoded-namessays to ask forencoding-type=url: without it S3 writes U+0001 as, which XML 1.0 forbids, and a CR in a key reads back as LF.Checks
cargo testpasses, including a new test for the raw+check and its reason.