Cover optional of a type with a private default constructor#355
Merged
gennaroprota merged 1 commit intoJul 22, 2026
Merged
Conversation
This adds a regression test for an optional whose value type keeps its default constructor private and grants friendship to `boost::serialization::access`. Such a type is not default constructible from the trait's point of view, so it takes the same reconstruct-on-load path as any other non-default-constructible type: the value is built through `load_construct_data`, whose default calls `access::construct`, and access reaches the private constructor. Before this, the archive demanded a publicly accessible default constructor, which broke this design. The type is exercised for both `boost::optional` and `std::optional` across every archive type. Closes issue #165.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a regression test for an optional whose value type keeps its default constructor private and grants friendship to
boost::serialization::access. Such a type is not default constructible from the trait's point of view, so it takes the same reconstruct-on-load path as any other non-default-constructible type: the value is built throughload_construct_data, whose default callsaccess::construct, and access reaches the private constructor. Before this, the archive demanded a publicly accessible default constructor, which broke this design.The type is exercised for both
boost::optionalandstd::optionalacross every archive type.Closes issue #165.