Repository navigation
Conversation
The CMake build selects the fcontext assembly by interpolating BOOST_CONTEXT_ARCHITECTURE into the source name, and sparc64 was not among the recognized values, so a CMake build on sparc64 fell through to the 64-bit default of x86_64 and failed to assemble. CMAKE_SYSTEM_PROCESSOR is "sparc64" there, which matches the existing *_sparc64_sysv_elf_gas.S sources, so listing it in _all_archs is enough. The remaining defaults are sysv, elf and gas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sparc64 is missing from
_all_archs, so a CMake build there falls through to the 64-bit default of x86_64 and fails to assemblejump_x86_64_sysv_elf_gas.S.This is the same fix as 81a8e50 for Alpha.
I tested it on an UltraSPARC T4 (Gentoo, gcc 16.2) with 1.92.0. CMake now picks sparc64, the library exports the fcontext symbols, and test_fiber, test_callcc and test_fcontext pass.