Fix do_postconf -# deleting the two lines after a key

[MrEbbinghaus]

Fixes #168

When a key is in main.cf both as a comment and as an active line, do_postconf -# deletes it with:

docker-postfix/image_root/scripts/common.sh

Line 159 in 3753771

sed -i -e "/^${key}\s*=/ { :a; N; /^\s/ba; N; d }" /etc/postfix/main.cf

The loop should collect continuation lines, but /^\s/ tests the start of the pattern space, which is always the key line. So it never loops. The extra N makes it always delete the key line plus the next two lines, whatever they are.

Fix

Use postconf -X "${key}", which removes a parameter together with its continuation lines.

Side note

Two existing tests have a mid-test ! grep … line. Bats ignores the status of negated commands unless they are the last line, so these lines can never fail.

[bokysan]

This is indeed a cool find. Thank you!

[MrEbbinghaus]

Just took 2.5 years. :-)