Repository navigation
Add tini to Dockerfile - #252
Conversation
Fixes the container not stopping upon `SIGTERM`
|
Hi, thank you so much for the commit. I have no issues adding But could I kindly as you explain here, for reference, explicit use case you've been running into? I have had no issues and neither did anyone else complain until now. |
|
Maybe I am doing something wrong, but my tests, without I guessed that the reason is because You can see this with the |
|
This is interesting. I have not run into these issues myself. We also have a lot of automated tests inside the project which spin containers up and down and they stop without any issues on GitHub's testing environment as well. I will approve this commit, as I nothing wrong with using Thank you for your effort. |
Right now, upon
docker stop, the container does not catch theSIGTERMand thus does not stop until after the timeout and aSIGKILLis issued.This uses
tinias an entrypoint, which fixes this issue