Repository navigation
ci: skip unused Pages artifact uploads on pull requests - #40
Merged
Merged
Conversation
PR docs jobs still build, check, and smoke the site, but they never deploy. Uploading the Pages artifact on those runs stalled the Mac minis for tens of seconds. Keep the upload for main/workflow_dispatch, and cancel in-progress jobs only on pull requests. Co-authored-by: Joe Blau <[email protected]>
joeblau
marked this pull request as ready for review
October 20, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up haptic CI on the self-hosted Mac mini runners (
[self-hosted, macOS, ARM64]) without moving any job off the minis.Timing (Oct 17–20)
Verified against Documentation workflow history:
buildjobs always ranactions/upload-pages-artifact@v5afterdocs:build/docs:smoke. Successful PR uploads were 7–70s (median ~43s among completed successes; the earlier analysis’s p50 of 35s is in the same range).deployjob was skipped on every PR in that window (skippedorcancelled). Livesmoketherefore never ran on PRs either.package-manager-cache: falseis unchanged on everysetup-nodestep. The minis keep their local npm cache.Changes
.github/workflows/docs.yml).actions/upload-pages-artifact@v5and thegtarpreflight now run only whengithub.event_name != 'pull_request'. Push-to-main andworkflow_dispatchstill upload sodeploycan consume the artifact.npm ci,npm run build,docs:check,docs:build, install Playwright, anddocs:smoke. Failure artifacts are unchanged.cancel-in-progress: truealso aborted in-flight main deploys. Both workflows now usecancel-in-progress: ${{ github.event_name == 'pull_request' }}. Publish npm stayscancel-in-progress: false.runs-onchange. Fork-PR skip guards from ci(security): skip self-hosted runner jobs for fork PRs #34 are unchanged.docs/ci-runners.md): Pages artifact is for deploy, not PR validation; PR concurrency cancels superseded runs without cancelling main deploys.Do not merge until Tests and Documentation are green on the minis for this PR.