Repository navigation
ci: speed up Font delivery quality without weakening checks - #12
Merged
Merged
Conversation
Skip the suite at the job level when unrelated paths change so required checks still report. Cache Playwright browsers and the generated npm font build, and shard production browser checks per engine. Co-authored-by: Joe Blau <[email protected]>
Keep the quality suite honest after a restore, and re-run CI against warm Playwright and font-build caches. Co-authored-by: Joe Blau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up the Font delivery quality workflow without dropping any existing checks.
Changes
on.pull_request.paths, so the workflow always starts. Unrelated PRs skip the expensive jobs (skipped = success); required checks are not left pending. Adocsaggregator still fails if any browser shard fails, so splitting the matrix does not weaken a requireddocscheck.~/.cache/ms-playwright), keyed per OS + browser + lockfile.packages/npm/{fonts,css,native,manifest.json,…}), keyed on a hash of the source fonts, CSS, and build scripts. Tests andnpm packstill run against the restored output.chromium/firefox/webkitmatrix (--project+--workers=1). Lint, typecheck, docs build, and unit tests stay once indocs-build.All previous commands still run: package build (or cache restore of the same artifacts),
npm test, next-fixture check/build/export, pack, lint, typecheck, docs build, unit tests, and Playwright against Chromium, Firefox, and WebKit.Duration
Before (run 38672434303): 9m6s wall (nearby success 8m34s, the ~8.6 min baseline)
docs9m2s, of which production browser checks 7m10s (Chromium + Firefox + WebKit sequential)assets7m44s, of which font generate 3m4s andnpm test4m0sAfter, cold caches (run 38936760197): 7m56s wall, all checks green
npm test4m3s; Playwright browsers downloaded per shardAfter, warm caches (run 38938016970): 5m58s wall, all checks green
assets4m35s (npm teststill 3m48s)--workers=1production suiteSteady-state wall clock is about 3 minutes faster than the 9m6s before run (~34%), and about 2.5 minutes faster than the 8.6 min baseline. First-run (cold cache) is already ~1 minute faster from sharding alone.