Repository navigation
test: add external signing and lifecycle verification (#39) - #56
Merged
Merged
Conversation
joeblau
force-pushed
the
feat/byow-testnet-e2e
branch
from
October 18, 2026 17:33
dcc4675 to
5725150
Compare
cursor Bot
pushed a commit
that referenced
this pull request
Oct 18, 2026
Keep #56 testnet harness updates and the NPM_TOKEN publish path (no OIDC trusted publishing or automatic provenance). Co-authored-by: Joe Blau <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testnet harness now supports approvals from a caller-controlled external wallet without receiving its private key, alongside the separate CI-only disposable test signer. Production users continue to bring their own wallet and Privy app.
The fifteen-stage lifecycle checks exact exchange prices, correlated order events and replay, trading after rotation, final revocation and audit integrity. Cleanup tracks both agents before approval, verifies zero remaining orders/agents/positions and confirms runner exit before exporting journals. The nightly job preserves the self-hosted Mac runner setup and uses a fresh Linux container for wallet state. Schema 2 reports and the nightly CI summary reject missing or incomplete evidence; stale journals cannot be reused as current evidence. Relay remains an explicit zero-value mock backed by pre-funded test collateral.
Validation: build, lint, typecheck, 229 offline tests, docs checks and static docs build pass. Tests cover real EIP-712 signature recovery, actual CLI approval payload compatibility, interrupted rotation, malformed/excessive follower output, process shutdown and report verification. A clean Linux ARM64 / Node 24 container also passed install/build and produced the expected validated missing-configuration failure report with zero lifecycle stages. No live trading or production credentials were used.
Refs #39 and the bring-your-own-wallet requirement in #11. #39 remains open: the testnet environment needs dedicated QA configuration, and acceptance still requires a credentialed nightly run plus a separate coding-agent skill session with journal evidence. The deterministic harness does not claim that independent session.