Repository navigation
Avoid leaking connection if connection.close is received during shutdown - #109
Merged
Merged
Conversation
flamble
approved these changes
Nov 5, 2026
michalovits
force-pushed
the
reconnect-after-close
branch
from
November 5, 2026 12:45
e51f161 to
b1c99db
Compare
michalovits
force-pushed
the
reconnect-after-close
branch
from
November 5, 2026 12:47
b1c99db to
648821f
Compare
michalovits
enabled auto-merge (squash)
November 5, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record our intent to shut down so that we don't revive the connection and leave it hanging around. Ensure we implement these parts of the 0-9-1 spec:
After sending [Connection.Close], any received methods except Close and Close-OK MUST be discarded.The response to receiving a Close after sending Close must be to send Close-Ok.