Repository navigation
Add metrics for external targets - #178
Open
stieler-it wants to merge 1 commit into
Open
stieler-it wants to merge 1 commit into
stieler-it wants to merge 1 commit into
Conversation
Signed-off-by: Michael Cornel <[email protected]>
stieler-it
force-pushed
the
target-metrics
branch
from
October 16, 2026 21:27
c25edc5 to
f1ca289
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #92, #127
Describe your changes
--tcp-targets,--dns-targetsand--http-targetschecked only exposed response times in the JSON/checkresponse and bumped an error counter on failure - there was no gauge for current up/down status and no latency histogram, so Prometheus couldn't track these targets the way it already tracks peer pings. This has been added in this PR.Testing performed
I have built a new Docker image based on this changes and am running it in our test environment. I have access to the metrics in Prometheus/Grafana and could not notice and regression.
Additional context
The removed gate in
updater.gofixes a bug that probably went unnoticed until now as its only impact was too low error numbers under certain conditions. Now it becomes important to make sure Prometheus metrics are updated.