Repository navigation
feat(helm): add HTTPRoute support - #160
Merged
Merged
Conversation
Closed
Signed-off-by: camaeel <[email protected]>
camaeel
force-pushed
the
feature/http-route
branch
from
January 24, 2026 22:01
cf63683 to
319ad3e
Compare
Contributor
Author
|
@skamboj Can you review this MR? |
camaeel
force-pushed
the
feature/http-route
branch
from
January 28, 2026 07:26
045778b to
319ad3e
Compare
Contributor
Author
|
@skamboj any chance to finalzie this small PR? |
Signed-off-by: Sachin Kamboj <[email protected]>
annotations: was indented under labels:, so any httproute.annotations were rendered as extra labels and the HTTPRoute got no annotations. Lay out metadata the same way as the Ingress template. Signed-off-by: Sachin Kamboj <[email protected]>
Rename the values key to httpRoute to match the chart's other multi-word keys (serviceAccount, serviceMonitor, prometheusRule) and the template to httproute.yaml to match servicemonitor.yaml and prometheusrule.yaml. Use the declared $svcPort as the Ingress template does, and drop trailing whitespace in values.yaml. Signed-off-by: Sachin Kamboj <[email protected]>
HTTPRoute support is a new, backwards-compatible chart feature. appVersion is unchanged. chart-releaser only publishes a chart when its version changes. Signed-off-by: Sachin Kamboj <[email protected]>
Contributor
|
Thanks for this, and sorry it took so long to review. I've pushed a few commits on top as maintainer edits:
Tested on a 3-node cluster with Istio's Gateway API implementation: the route attaches to a Gateway listener and serves the UI. Disabling removes it, re-enabling recreates it, and annotations are added and removed correctly. With default values the rendered chart is unchanged. |
Contributor
Author
|
@skamboj thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159
Describe your changes
Add HTTPRoute support
Testing performed
I did
helm templatewith required values set and installed on local clusterAdditional context
N/A