Validate offload block request lengths - #6166
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
cdb2jdbc
triggersc_latency
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
|
/adhoc-test triggersc_latency cdb2jdbc |
akshatsikarwar
left a comment
akshatsikarwar
left a comment
There was a problem hiding this comment.
Please check why cdb2jdbc, triggersc_latency tests failed
|
/adhoc-test triggersc_latency cdb2jdbc |
Check the received and declared payload sizes before processing block requests and add defensive bounds checks to block request handling. The payload offset is derived with offsetof() rather than sizeof(), since the message struct ends in a flexible-style array and sizeof() may include trailing padding. Signed-off-by: Walid Nejmi <[email protected]>
dde81b2 to
dbca9e1
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
sc_resume
recover_deadlock
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
timepart_retro
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
4 participants
Check the received and declared payload sizes before processing block requests and add defensive bounds checks to block request handling.
The payload offset is derived with offsetof() rather than sizeof(), since the message struct ends in a flexible-style array and sizeof() may include trailing padding.
To help us review your pull request, please consider providing an overview of the following: