Cluster changes for wsl - #6130
Open
chands10 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Salil Chandra <[email protected]>
roborivers
approved these changes
Aug 12, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
cdb2jdbc
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
emelialei88
added a commit
to emelialei88/comdb2
that referenced
this pull request
Aug 20, 2026
"setup" re-runs this script inside m0, where the guard at the bottom demanded ~/.local/share/comdb2-util and otherwise bailed out. That directory is only there because "build" bakes a copy into the image, and the in-container half of setup does not want it anyway: it reads $CLUSTER from .bash_profile and never opens config.sqlite. On WSL the copy is missing and setup died before doing any work. Based on Salil Chandra's fix in bloomberg#6130, without the /proc/self/cgroup half of the container test - under cgroup v2 that file reads "0::/", so the second field is always empty and /.dockerenv was carrying the condition on its own. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Emelia Lei <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help us review your pull request, please consider providing an overview of the following: