Skip to content

Fix no-op heading ternary in draft input scene - #82

Open
jay23606 wants to merge 1 commit into
blixvip:mainfrom
jay23606:pr-go/55-fix-the-no-op-heading-ternary-in-the-dra
Open

jay23606 wants to merge 1 commit into
blixvip:mainfrom
jay23606:pr-go/55-fix-the-no-op-heading-ternary-in-the-dra

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Bug

KINDS.input() in public/drafts.mjs sets the prompt box's top with ${o.h ? 130 : 130}. Both branches are 130, so the box stays at the same height whether or not a heading is shown. With a heading, the box sits close to the title (which occupies roughly 64–102px of the 360px frame).

Change

The heading branch now uses 150, which clears the title. The no-heading branch stays at 130, which centres the 100px-tall box in the 360px frame.

Testing

  • node --test test/drafts-input-position.test.js failed on the unfixed code (input scene box top must differ with and without a heading, expected 130 and actual 130) and passes after the change (# pass 1).
  • npm run check passes (Checked 47 UI files; no personal companion URLs.).

Fixes #55

Regression test: fails on base twice (/input scene box top must differ with and without a heading/), passes on fix twice (node --test test/drafts-input-position.test.js)

Fixes #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the no-op heading ternary in the draft "input" scene

1 participant