Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
KINDS.input()inpublic/drafts.mjssets the prompt box'stopwith${o.h ? 130 : 130}. Both branches are 130, so the box stays at the same height whether or not a heading is shown. With a heading, the box sits close to the title (which occupies roughly 64–102px of the 360px frame).Change
The heading branch now uses
150, which clears the title. The no-heading branch stays at130, which centres the 100px-tall box in the 360px frame.Testing
node --test test/drafts-input-position.test.jsfailed on the unfixed code (input scene box top must differ with and without a heading, expected 130 and actual 130) and passes after the change (# pass 1).npm run checkpasses (Checked 47 UI files; no personal companion URLs.).Fixes #55
Regression test: fails on base twice (/input scene box top must differ with and without a heading/), passes on fix twice (
node --test test/drafts-input-position.test.js)Fixes #55