Repository navigation
Stream MP4 exports directly to disk - #79
Conversation
Aaqibhafeezkhan
left a comment
There was a problem hiding this comment.
- Uses the existing vendored muxer capability.
- Disk streaming avoids the complete MP4 ArrayBuffer.
- Existing fallback retained.
- Picker cancellation handled.
- Writable stream closed after finalization.
- Failed writes aborted.
- Regression tests added.
- Single focused commit.
- Original files and unrelated changes preserved.
|
Thanks @Aaqibhafeez Khan, this is a clean way to get large exports off the tab's memory. Choosing the save location up front and streaming through
|
|
Thanks @Aaqibhafeezkhan, this is merged! Long exports no longer have to hold the whole MP4 in the tab: when the browser offers I ran it in real Chrome against the 30 s showcase reference with the picker pointed at an Origin Private File System handle. The stream path wrote a 22.7 MB file with a clean Next step if you want another one: good first issue #30, "Move the export crop math into a module and test it directly" (#30). You've just been in |
Summary
Streams exported MP4 files directly to disk using the File System Access API, avoiding the need to hold the complete encoded video in memory.
Changes
showSaveFilePicker()to select the output destination before rendering.FileSystemWritableFileStreamTargetfrom mp4-muxer.Existing export settings and audio/video encoding remain unchanged.
Closes #34