Repository navigation
Conversation
Owner
|
Thank you, @jay23606. This fixes a first-visit problem: a fresh clone now opens the editor demo with four clips whenever the library has enough segments, and the toast count matches the timeline. If you want another one, #77 — Point the docs at public/sections.mjs for section and beat timing is a good first issue and nobody has claimed it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The editor demo should have four clips whenever the library has at least four segments. On the base commit,
demoClipListonly returns the hardcoded picks, or the first segment of the first four references when no pick exists, so the demo can show fewer than four clips even when the library has at least four segments.The change
demoClipListinpublic/editor-model.mjsnow fills in this order:Duplicates are skipped, and the toast count comes from the real clip count.
Testing
node --test test/editor-demo.test.js: 4 pass with the fix. On the base commit, all 4 fail withdemoClipList missing: expected a function, got undefined.npm test: all tests pass (2 skipped).npm run check: passes.Fixes #69
Regression test: fails on base twice (/demoClipList missing: expected a function, got undefined/), passes on fix twice (
node --test test/editor-demo.test.js)Fixes #69