Repository navigation
fix(ui): repair two double-encoded UTF-8 strings in public/index.html - #71
Merged
Merged
Conversation
hussain-alsaibai
force-pushed
the
fix/mojibake-encoding
branch
from
November 15, 2026 13:52
6a77111 to
870ed9b
Compare
Owner
|
Merged, thanks @hussain-alsaibai! Using the escaped You already know the preview code from #66, so #68 (keep the preview Play/Pause button label in sync with the film) would be a natural next one. Comment there if you want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58.
Both spots are repaired in
public/index.html:U+00C3 U+2014) where the multiplication sign (U+00D7) was meant. It now matches the siblingmodalXbutton at line 1101.[-a-currency-quote-dash]sequence (U+00E2 U+20AC U+201C U+00E2 U+20AC U+201D), so the regex matcheda, the euro sign and curly quotes as separators and did not match an en or em dash at all. It is now the escaped form[\-\u2013\u2014], which survives any future re-encoding.The escaped form was chosen deliberately: the literal dashes would be re-corrupted by the same Latin-1 round-trip that produced the bug.
Verification
The check named in the issue now prints
false:And the separator now recognises all three dashes, where the old class did the opposite:
8 - seconds8 - seconds(en dash)8 - seconds(em dash)8 - seconds(curly quote)A codepoint census of the file confirms no
U+00C3orU+00E2remain (both were 1 and 2 before; now 0). The correct multiplication sign and dashes already appear elsewhere in the same file, so this was two isolated spots rather than a file-wide encoding problem - a scan found only these two, as the issue recorded.Test note
npm run checkpasses locally ("Checked 47 UI files; no personal companion URLs").npm testhas two failures in the audio-extraction tests (test/media.test.js,test/server.test.js):extractAudio reuses cached files and shares concurrent extractionandreference audio route extracts missing audio once and handles extraction failures. Both are pre-existing and unrelated - they need an ffmpeg build this container does not have, and I confirmed the identical404 !== 200failure with this change stashed, on unmodifiedmain.