Fix postal code being overwritten in setDomainContacts - #32
Merged
Merged
Conversation
setDomainContacts() was discarding any real postal_code value supplied in $vars, always falling back to $contact['zip'], and defaulting to '00000' when neither was present. Preserve an explicit postal_code when one is provided. Partial port of a8d5787 (upstream master) — only the postal_code fix; the DNSSEC get-endpoint fix from that commit is applied separately alongside the new DNSSEC feature port.
This was referenced Aug 21, 2026
Member
|
Code review passed — the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setDomainContacts()where the postal code field was being overwritten with the wrong value before being sent to the OpenSRS APITest plan