Assorted updates - #11
Conversation
Before: 239 KB (244.886 bytes) After: 86,0 KB (88.133 bytes)
80ce4b0 to
911b005
Compare
|
In a quick review, it looks good, and I appreciate you doing it. Only issue I saw was that the sitemap uses the document creation date, but I haven't checked whether that's an existing issue. |
|
I can't check the original sitemap because for some reason Cloudflare is blocking my IP...
|
|
Anyway, if the dates are an issue, I suggest that you update the front mater values to match the real dates because that's how Jekyll is supposed to work. |
| @echo "Cleaning Ruby dependencies..." | ||
| rm -rf .bundle/ | ||
| rm -rf vendor/ | ||
| rm -f Gemfile.lock |
There was a problem hiding this comment.
All these rm and find calls could be replaced with a git clean -dfx call if you only support repo runs.
EDIT: here's my suggestion
# Makefile for BleachBit documentation site
.PHONY: help clean serve build install update
# Default target
help:
@echo "Available targets:"
@echo " help - Show this help message"
@echo " clean - Remove generated files and dependencies"
@echo " serve - Start local development server"
@echo " build - Build the static site"
@echo " install - Install Ruby dependencies"
@echo " update - Update Ruby dependencies"
# Clean generated files and dependencies
clean:
@echo "Cleaning generated files..."
git clean -dfx
@echo "Collecting garbage in git..."
git gc
@echo "Clean complete."
# Install Ruby dependencies
install:
@echo "Installing Ruby dependencies..."
bundle install
@echo "Dependencies installed"
# Update Ruby dependencies
update:
@echo "Updating Ruby dependencies..."
bundle update
@echo "Dependencies updated."
@echo "Listing outdated dependencies..."
bundle outdated
# Build the static site
build:
@echo "Building site..."
bundle exec jekyll build
@echo "Site built in _site/"
# Serve locally for development
serve:
@echo "Starting development server..."
bundle exec jekyll serve --drafts
# Serve locally without drafts (production-like)
serve-prod:
@echo "Starting production-like server..."
bundle exec jekyll servebb6e61c to
64a1b69
Compare
|
OK, I think I got all the changes I wanted to make in. One change from your side is to set deploy for Pages to GitHub Actions. If anything else is needed, I will create a followup PR. |
Also, add the lock file to repo for reproducible builds
Add the needed tzinfo-data gem for Windows
- Use single backticks for inline code, not double or triple - Normalize list markers to "* " - Give every code fence a language (terminal and bash become sh) - faqs.yml: switch answers to block scalars, so a blank line is a real paragraph break
Google doesn't respect it
The original sitemap had no timestamps After your changes, the new sitemap has good timestamps. I verified |
|
Just remember to change deployment for pages to GitHub Actions in repo settings and everything should work. I can fix any issues that might arise later. |
@az0: please check the individual patches. A preview can be found on https://super-salamander-00b8ec.netlify.app. The sitemap is here: https://super-salamander-00b8ec.netlify.app/sitemap.xml