Skip to content

OTWO-7742 Remove Gravatar dependency in accounts page - #1957

Open
Niharika1117 wants to merge 4 commits into
stagingfrom
OTWO-7742
Open

Niharika1117 wants to merge 4 commits into
stagingfrom
OTWO-7742

Conversation

@Niharika1117

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved asset paths break admin avatar images and account Twitter image metadata.

1 open finding
What changed in this PR

Removes Gravatar requests from the shared avatar helper, replacing account avatars with local anonymous images.

Changes:

  • Returns anonymous images instead of Gravatar URLs.
  • Updates tests for local fallback images and size clamping.
File Description
test/​helpers/​avatar_helper_test.rb Updates fallback image and size assertions.
app/​helpers/​avatar_helper.rb Replaces Gravatar URLs with anonymous asset paths.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread app/helpers/avatar_helper.rb Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Configuring an asset host still routes account avatars through Gravatar.

1 open finding
1 resolved since last review

🧠 Review effort: Balanced

Comment thread app/helpers/avatar_helper.rb Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Direct URL consumers lose anonymous-avatar fallbacks, and the account header no longer respects mobile avatar sizing.

3 open issues

Review effort: Balanced

Comment thread app/helpers/avatar_helper.rb
Comment thread app/views/accounts/show/_header.html.haml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants