Repository navigation
Answers: notice at the end, knowledge spaces in colour, hover highlights - #4
Merged
Merged
Conversation
- the answer's notice moves below the answer text - an answer mixing knowledge spaces colours each space: its [N] citation badges, the passages they back (underlined) and its source chips, with a legend naming the spaces; each notice carries its space's colour - [N] markers render as badges; hovering (or focusing) a source chip highlights the passages it backs, hovering a badge its passage - source chips show the [N] they back; duplicates of one page merge - only sources with an explicit ref resolve a marker (agent turns number facts, not sources) Same rules as the Weave web chat and Weave-API's knowledge_spaces answer metadata (bl0rb/Weave, services/chat and services/api). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FbB4c9JMD1Viygu2k8
The answer renderer showed tables as raw "|" lines, restarted numbering at 1 after any interruption, flattened nested lists, left block quotes, rules, __bold__ and <br> as raw text and split every line into its own paragraph. It now renders tables, nested lists, numbered lists with their start number (indented lines continue an item), block quotes, rules, __bold__, <https://…> links and <br>, and keeps single line breaks inside a paragraph. Still HTML-escaped first; only the tags built here are produced. Citation marking also covers table cells and headings. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FbB4c9JMD1Viygu2k8
The mark picked one of four motions per start (weave, turn, flip, shuttle) and ended a finite run with a small scale pulse. It now only weaves (the weft rows unweave and shuttle back in); the mark itself stays still and the end-of-run settle has no visible motion. Mirrors bl0rb/Weave's packages/weave-mark and web apps. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01W9t7FbB4c9JMD1Viygu2k8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop counterpart of the chat changes in bl0rb/Weave#443.
Changes
[N]citation badges, the passages they back (underlined) and its source chips, with a legend naming the spaces. Each notice carries its space's colour.[N]markers render as badges. Hovering (or focusing) a source chip highlights the passages it backs; hovering a badge highlights its passage.[N]they back; duplicate chunks of one page merge into one chip.refresolve a marker (agent turns number facts, not sources), so their markers stay plain text.Same rules as the Weave web chat (
services/chat) and Weave-API's newknowledge_spacesanswer metadata. The logic lives in the newui/citations.js(no dependencies);ui/panel.js,ui/style.css(space colours for light and dark) andui/common.js(EN strings) are wired to it.Testing
ui/citations.jschecked in jsdom: space order and colours, passage/marker segmentation (incl.[2][3], nested lists, code blocks untouched, unknown[7]left as text), highlight on/off.node --checkonui/panel.jsandui/citations.js.A release (0.1.10) is needed to ship it.
Generated by Claude Code