Skip to content

Refactor: Do not call add_node_to_maps in validate_activities #237

New issue
New issue
Closed
#238
Closed
Refactor: Do not call add_node_to_maps in validate_activities#237
#238
Labels
nitSmall nitpicks that are picked up in testing.

Description

@chuksys
chuksys
opened on Mar 26, 2025

Create ActivityValidationParams struct and pass to validate_activities to improve testability and reduce coupling.

          Pass these in rather than calling `add_node_to_maps` here

Originally posted by @carlaKC in #232 (comment)

Activity

  1. chuksys
    changed the title [-]sim-cli/refactor: create ActivityValidationParams struct and pass to validate_activities to improve testability and reduce coupling.[/-] [+]sim-cli/refactor: Improve testability and reduce coupling.[/+] on Mar 26, 2025
  2. carlaKC
    changed the title [-]sim-cli/refactor: Improve testability and reduce coupling.[/-] [+]sim-cli/refactor: Do not call add_node_to_maps in validate_activities[/+] on Mar 28, 2025
  3. carlaKC
    changed the title [-]sim-cli/refactor: Do not call add_node_to_maps in validate_activities[/-] [+]Refactor: Do not call add_node_to_maps in validate_activities[/+] on Mar 28, 2025
  4. carlaKC
    added
    nitSmall nitpicks that are picked up in testing.
    on Mar 28, 2025
  5. carlaKC
    closed this as completedin #238on Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    nitSmall nitpicks that are picked up in testing.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions