Repository navigation
[pull] develop from smartcontractkit:develop - #628
Merged
Merged
Conversation
The single-instance check was broken in two ways: it was global, so a shard_assignment job could not run alongside a settings job, and the activeJobID pointer was never stored, so the 'already active' error could never actually fire. Track the active job ID per config type (settings / shard_assignment) in a sync.Map. ServicesForSpec validates the config type and claims the slot atomically via LoadOrStore, so one settings job and one shard_assignment job may coexist while a second job of the same type is rejected. OnDeleteJob frees the slot only if it is held by the deleted job's ID, so deleting a rejected duplicate cannot evict the active job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )