Repository navigation
feat: prioritize longhorn storage class and use it as default - #146
Merged
Merged
Conversation
Sort available storage classes so longhorn is always listed before local-path, with remaining entries alphabetical. New volume dialogs for apps and agents now default to longhorn when available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
longhornis always listed beforelocal-path, with all remaining entries sorted alphabetically.longhornwhen available, otherwise fall back to the first available class.Details
StorageClassUtils(src/shared/utils/storage-class.utils.ts) withsortStorageClasses()andgetDefaultStorageClass().cluster.service.tsgetStorageClasses()now sorts via the utility.storage-edit-overlay.tsx(apps) andagent-volume-edit-overlay.tsx(agents) to use the longhorn-aware default.Tests
storage-class.utils.unit.spec.ts.yarn vitest run src/shared/utils/storage-class.utils.unit.spec.ts-> 7 passed.