Rust feature/rls - #318
Merged
Merged
Rust feature/rls#318
Conversation
This reverts commit cb351cb.
…g vals in RLS alg
bglid
commented
Sep 17, 2026
bglid
commented
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 17, 2026
elnaske
reviewed
Sep 20, 2026
elnaske
reviewed
Sep 20, 2026
elnaske
reviewed
Sep 20, 2026
Owner
Author
|
Thanks again for doing that. Going to revert |
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
elnaske
reviewed
Sep 25, 2026
Owner
Author
Ayy thank you. The help and guidance was greatly appreciated. Learned a lot through this one with regard to Rust so I appreciate your patience lol. Should be all set now addressing those last points. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds RLS algorithm port.
Changes
rls.rs+ full pipeline to export python bindings.test_filters.pyandtest_bindings.pyin parameterized testserror.rsthat are specific to RLS algorithmfloat64infd_filter_model.pythat causes warning.update_step()to be&mut selfsince RLS has a mutable state in the form of it'sp_matrixcontaining previous history. Updates tests forLmsandNlmsalongside.Questions requesting check on:
unwrap()inupdate_step()appropriate and checked?update_step()tomutactually fine here? Any considerations?Related Issue
Part of #307