Name the gitleaks step for the range it actually scans - #6
Merged
Conversation
The step was called "gitleaks over full history" and never scanned full history on either trigger: the action reads the commit range of the event, one commit on a pull request and the pushed range on a push, against 41 on main. fetch-depth: 0 makes that range resolvable rather than wider. Full history is the identity job's --all-history run. The job name, and so the required check context, is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The step claimed full history and never scanned it on either trigger:
Against 41 commits on
main.fetch-depth: 0makes the range resolvable, not wider. Full history is covered by theidentityjob, which runspre-push --all-history.The incremental scan is the value here, so this renames the step rather than widening the job. The job name — and therefore the required status check context
gitleaks— is unchanged.