Skip to content

Strip a tag's signature before parsing its trailers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bezilla merged 1 commit into from
Sep 6, 2026
Merged

Strip a tag's signature before parsing its trailers #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .githooks/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,14 @@ if [ -n "$tags" ]; then
[ "$tagger" = "$CANONICAL" ] ||
fail "tag ${ref#refs/tags/} tagger is '${tagger}', expected '${CANONICAL}'"

# Everything after the header's blank line is the annotation body.
check_trailers "tag ${ref#refs/tags/}" "$(printf '%s\n' "$raw" | sed '1,/^$/d')" || exit 1
# The annotation body is everything after the header's blank line, minus
# any signature. A signed tag appends its signature block straight after
# the message with no blank line between -- so the last paragraph becomes
# message-plus-signature, which does not parse as trailers and would make
# this check silently pass on every signed tag. Strip the signature, then
# parse.
body="$(printf '%s\n' "$raw" | sed '1,/^$/d' | sed '/^-----BEGIN .*SIGNATURE-----$/,$d')"
check_trailers "tag ${ref#refs/tags/}" "$body" || exit 1
done <<< "$tags"
fi

Expand Down
Loading