Skip to content

Avoid timestamp writes for unchanged CMS content types - #278

Merged
olliethedev merged 2 commits into
mainfrom
fix/cms-sync-unchanged
Sep 17, 2026
Merged

olliethedev merged 2 commits into
mainfrom
fix/cms-sync-unchanged

Conversation

@olliethedev

@olliethedev olliethedev commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • A fresh CMS plugin instance updates every configured content type even when nothing changed. That advances updatedAt and changes serialized content on cold starts, amplifying downstream ISR writes (olliethedev/bio-mogging#101).
  • Compare name, normalized optional description, structural JSON schema, legacy field configuration and form version before updating. Preserve JSON array order and repair malformed stored schemas. Changed definitions still migrate normally.
  • Prepare @btst/stack and @btst/codegen 3.1.2 for the repository's paired release workflow; no application API changes.

Type of change

  • Bug fix
  • New plugin
  • Feature / enhancement to an existing plugin
  • Documentation
  • Chore / refactor / tooling

Checklist

  • pnpm build passes
  • pnpm typecheck passes
  • pnpm lint passes
  • Tests added or updated (unit and/or E2E): 10 new memory-adapter regressions; full stack suite passes in CI
  • Docs updated (docs/content/docs/); docs production build passes
  • All three codegen-projects create successfully and pass hosted E2E tests
  • New plugin: not applicable

Registry regeneration produced no changes. Cold-start tests use separate plugin instances against the same memory adapter and assert zero updates plus identical serialized output. Tests also cover whitespace/metadata key ordering, changed fields, malformed schemas, meaningful array ordering and CMS form property reordering. All CI and both Vercel deployments pass on the final head; the review finding is addressed and resolved, and the final Codex review has no findings.

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
better-stack-docs Ready Ready Preview Sep 17, 2026 9:52pm UTC
better-stack-playground Ready Ready Preview Sep 17, 2026 9:52pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T21:55:26.242992Z c15d39e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddab335723

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/stack/src/plugins/cms/api/plugin.ts Outdated
@olliethedev

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: c15d39e57f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@olliethedev
olliethedev merged commit 48cb6e8 into main Sep 17, 2026
14 checks passed

This branch was successfully deployed

2 active deployments
Preview – better-stack-docs c15d39e5 Deployed Sep 17, 2026 by vercel[bot]
Preview – better-stack-playground c15d39e5 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant