Repository navigation
Keep PR documentation builds from publishing GitHub Pages - #2
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A documentation PR could publish the public site: run29936805366 (July22) successfully force-pushed
gh-pagesfrom a pull_request event. The workflow now builds on the same main push, PR and manual triggers with a read-only token, then passes its existing HTML output through a one-day artifact to a separate publish job.Publication requires a successful
cijob,refs/heads/main, and a push or manual event. Only that publish job receives contents:write. PR builds retain the original Python3.10 dependency and Sphinx commands and cannot run the publisher. The target branch, HTML directory, self-hosted runner and force-orphan publication behavior on approved main runs are preserved.Validation: actionlint v1.7.12 and diff checks pass. Exact
uv sync --all-groupsanduv run sphinx-build -M html doc/source doc/buildcommands pass locally (90 existing documentation warnings). Hosted run37726993414 passes ci (3.10) in6m33s, including the unchanged documentation build and one-day artifact upload; publish is SKIPPED. Its actual token reports only Contents:read and Metadata:read. The worker does not merge this PR or deploy Pages; merging into main invokes publication and needs the orchestrator's separate deployment approval handling.