Repository navigation
Preserve empty method names - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@method(name="")now registers the empty name. Before, it silently registered the function's name, so requests with an empty method name missed it.The request schema accepts empty names. The decorator now uses the function's name only when
nameis None.The regression failed before the fix. It checks replacing an existing empty-name method and dispatching a request through the default method collection.
Checked with
python -m pytest --cov --cov-report=term-missingon Python 3.8 and 3.13: 345 tests passed with 100% line and branch coverage.ruff check .,ruff format --check .,mypy,pyrightandmkdocs build --strictpassed.