Skip to content

Fix various detail#100

Merged
dietmarkuehl merged 2 commits into
mainfrom
fix-various-detail
Jul 18, 2026
Merged

Fix various detail#100
dietmarkuehl merged 2 commits into
mainfrom
fix-various-detail

Conversation

@dietmarkuehl

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings July 18, 2026 21:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes public include paths by introducing a top-level beman/task.hpp umbrella header and updating tests, examples, and documentation to prefer umbrella headers (e.g., beman/task.hpp, beman/execution.hpp) over deeper include paths.

Changes:

  • Add include/beman/task.hpp as a public umbrella header and export it via the header file set.
  • Update examples/tests/README to include beman/task.hpp and beman/execution.hpp instead of beman/task/task.hpp and beman/execution/execution.hpp.
  • Update internal Doxygen \headerfile references to point at the new umbrella include.

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/beman/task/task.test.cpp Switch test includes to umbrella headers.
src/beman/task/CMakeLists.txt Export the new include/beman/task.hpp header via the public header file set.
README.md Update example snippet includes to umbrella headers and refresh the Compiler Explorer link.
include/beman/task/task.hpp Use beman/execution.hpp umbrella header instead of the deeper execution include.
include/beman/task/detail/with_error.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/task_scheduler.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/sub_visit.hpp Update Doxygen \headerfile references to the umbrella header.
include/beman/task/detail/scheduler_of.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/result_type.hpp Update Doxygen \headerfile references to the umbrella header.
include/beman/task/detail/promise_base.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/poly.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/find_allocator.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/allocator_support.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task/detail/allocator_of.hpp Update Doxygen \headerfile reference to the umbrella header.
include/beman/task.hpp New umbrella header for beman::task.
examples/task_scheduler.cpp Update example includes to umbrella headers.
examples/stop.cpp Update example includes to umbrella headers (execution/stop_token/task).
examples/rvalue_task.cpp Update example includes to umbrella headers.
examples/result_example.cpp Update example includes to umbrella headers.
examples/query.cpp Update example includes to umbrella headers.
examples/loop.cpp Update example includes to umbrella headers.
examples/into_optional.cpp Update example includes to umbrella headers.
examples/friendly.cpp Update example includes to umbrella headers.
examples/escaped_exception.cpp Update example includes to umbrella headers.
examples/error.cpp Update example includes to umbrella headers.
examples/environment.cpp Update example includes to umbrella headers (task/execution/net).
examples/dangling_references.cpp Update example includes to umbrella headers.
examples/customize.cpp Update example includes to umbrella headers.
examples/cppnow_with_error.cpp Update example includes to umbrella headers.
examples/cppnow_stop_token.cpp Update example includes to umbrella headers (task/execution/stop_token).
examples/cppnow_return.cpp Update example includes to umbrella headers.
examples/cppnow_result_types.cpp Update example includes to umbrella headers.
examples/cppnow_query.cpp Update example includes to umbrella headers.
examples/cppnow_errors.cpp Update example includes to umbrella headers.
examples/cppnow_cancel.cpp Update example includes to umbrella headers.
examples/cppnow_basic.cpp Update example includes to umbrella headers.
examples/cppnow_allocator.cpp Update example includes to umbrella headers.
examples/cppnow_affinity.cpp Update example includes to umbrella headers (task/execution/stop_token).
examples/container.cpp Update example includes to umbrella headers.
examples/co_await_result.cpp Update example includes to umbrella headers.
examples/async_lock.cpp Update example includes to umbrella headers.
examples/alloc.cpp Update example includes to umbrella headers.
examples/aggregate_return.cpp Update example includes to umbrella headers.
examples/affinity.cpp Update example includes to umbrella headers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/environment.cpp
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 92.857%. remained the same — fix-various-detail into main

@dietmarkuehl
dietmarkuehl merged commit be657d7 into main Jul 18, 2026
37 checks passed
@dietmarkuehl
dietmarkuehl deleted the fix-various-detail branch July 18, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants