Fix various detail#100
Merged
Merged
Conversation
dietmarkuehl
requested review from
bretbrownjr,
steve-downey and
wusatosi
as code owners
July 18, 2026 21:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes public include paths by introducing a top-level beman/task.hpp umbrella header and updating tests, examples, and documentation to prefer umbrella headers (e.g., beman/task.hpp, beman/execution.hpp) over deeper include paths.
Changes:
- Add
include/beman/task.hppas a public umbrella header and export it via the header file set. - Update examples/tests/README to include
beman/task.hppandbeman/execution.hppinstead ofbeman/task/task.hppandbeman/execution/execution.hpp. - Update internal Doxygen
\headerfilereferences to point at the new umbrella include.
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/beman/task/task.test.cpp | Switch test includes to umbrella headers. |
| src/beman/task/CMakeLists.txt | Export the new include/beman/task.hpp header via the public header file set. |
| README.md | Update example snippet includes to umbrella headers and refresh the Compiler Explorer link. |
| include/beman/task/task.hpp | Use beman/execution.hpp umbrella header instead of the deeper execution include. |
| include/beman/task/detail/with_error.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/task_scheduler.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/sub_visit.hpp | Update Doxygen \headerfile references to the umbrella header. |
| include/beman/task/detail/scheduler_of.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/result_type.hpp | Update Doxygen \headerfile references to the umbrella header. |
| include/beman/task/detail/promise_base.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/poly.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/find_allocator.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/allocator_support.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task/detail/allocator_of.hpp | Update Doxygen \headerfile reference to the umbrella header. |
| include/beman/task.hpp | New umbrella header for beman::task. |
| examples/task_scheduler.cpp | Update example includes to umbrella headers. |
| examples/stop.cpp | Update example includes to umbrella headers (execution/stop_token/task). |
| examples/rvalue_task.cpp | Update example includes to umbrella headers. |
| examples/result_example.cpp | Update example includes to umbrella headers. |
| examples/query.cpp | Update example includes to umbrella headers. |
| examples/loop.cpp | Update example includes to umbrella headers. |
| examples/into_optional.cpp | Update example includes to umbrella headers. |
| examples/friendly.cpp | Update example includes to umbrella headers. |
| examples/escaped_exception.cpp | Update example includes to umbrella headers. |
| examples/error.cpp | Update example includes to umbrella headers. |
| examples/environment.cpp | Update example includes to umbrella headers (task/execution/net). |
| examples/dangling_references.cpp | Update example includes to umbrella headers. |
| examples/customize.cpp | Update example includes to umbrella headers. |
| examples/cppnow_with_error.cpp | Update example includes to umbrella headers. |
| examples/cppnow_stop_token.cpp | Update example includes to umbrella headers (task/execution/stop_token). |
| examples/cppnow_return.cpp | Update example includes to umbrella headers. |
| examples/cppnow_result_types.cpp | Update example includes to umbrella headers. |
| examples/cppnow_query.cpp | Update example includes to umbrella headers. |
| examples/cppnow_errors.cpp | Update example includes to umbrella headers. |
| examples/cppnow_cancel.cpp | Update example includes to umbrella headers. |
| examples/cppnow_basic.cpp | Update example includes to umbrella headers. |
| examples/cppnow_allocator.cpp | Update example includes to umbrella headers. |
| examples/cppnow_affinity.cpp | Update example includes to umbrella headers (task/execution/stop_token). |
| examples/container.cpp | Update example includes to umbrella headers. |
| examples/co_await_result.cpp | Update example includes to umbrella headers. |
| examples/async_lock.cpp | Update example includes to umbrella headers. |
| examples/alloc.cpp | Update example includes to umbrella headers. |
| examples/aggregate_return.cpp | Update example includes to umbrella headers. |
| examples/affinity.cpp | Update example includes to umbrella headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.