Repository navigation
Prepare the 1.18.0 release - #246
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Release notes and Composer requirements CHANGELOG.md, composer.json |
The changelog records 1.18.0 compatibility notes. Composer constraints and suggestions change, and an autoload path gains a trailing slash. |
Cache dependency rules docs/llms-full.txt |
The documentation specifies when a cached embedded child becomes a parent dependency. It also describes purge behavior for eagerly read children and rendered holes. |
Test purger reset
| Layer / File(s) | Summary |
|---|---|
Reset purger state in the test tests/FakeCountingPurger.php, tests/RefreshAnnotatedCommandTest.php |
The test helper adds reset() to clear recorded tags. The test calls it instead of clearing the property directly. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- Issue 241 — The documentation clarifies that an eagerly fetched child does not become a cache dependency unless it meets the documented caching conditions.
Merge Risk: 
Minimal · up to f2536
-
No confirmed issue remains that should block merging this release preparation.
Pre-merge checks: 
3 · 
1 · 
1
-
Failed checks: 1 warning · 1 inconclusive Passed checks: 3 passed-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (3 skipped: 3 unsupported.)
Full details: Description check
-
Explanation
The description directly matches the changeset. It covers the 1.18.0 release preparation, dependency updates, Symfony 8 support, PHPStan changes, cache-dependency documentation, test reset changes, autoload correction, and changelog update.
-
Full details: Out of Scope Changes check
-
Explanation
#244is limited to development tooling and the two findings intests/RefreshAnnotatedCommandTest.php. The PR also changes released-package dependency constraints and suggestions incomposer.json, cache-dependency documentation indocs/llms-full.txt, and the release changelog inCHANGELOG.md. These changes do not implement#244and are outside its stated scope.Resolution
Limit this PR to the
#244tooling lock and test changes. Move thecomposer.json,docs/llms-full.txt, andCHANGELOG.mdchanges to a separate PR with applicable active issue scope.
Full details: Linked Issues check
-
Explanation
For
#244, the reviewed source changes addFakeCountingPurger::reset()and use it intests/RefreshAnnotatedCommandTest.php. This addresses the reported PHPStan inference findings. The requiredvendor-bin/tools/composer.lockchange cannot be reviewed because the path is excluded by!**/*.lock. The PR description reports PHPStan 2.3.3, but the reviewed evidence does not independently establish the lock contents at the reviewed head.Resolution
Provide reviewable evidence for
vendor-bin/tools/composer.lockat the reviewed head that PHPStan is 2.3.x and that the lock change is limited to the required development-tool update.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Verification (local, PHP 8.4.25):
PHP 8.2 and the lowest-dependency combinations are left to CI. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #246 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 582 582
===========================================
Files 102 102
Lines 1543 1543
===========================================
Hits 1543 1543 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performed
|
…drop the unreachable symfony/cache 5 range
|
@coderabbitai review |
|
Release preparation for 1.18.0, on top of #245.
array{}acrossput().llms-full.txt(refs #[Cacheable] の付いていないリソースをEmbedすると、onGet() で値を読んでも依存にならない #241): the Cache Dependencies section says that only a cached embedded child becomes a dependency. The example uses#[Embed]instead of an eager$this->resource->get(), which is not tracked. The user-facing explanation for #[Cacheable] の付いていないリソースをEmbedすると、onGet() で値を読んでも依存にならない #241 goes to the manual.symfony/cache-contractsis dropped: it is unused insrc, andsymfony/cacherequires it anyway.suggestadds the packages this library's own modules need:bear/fastly-module(FastlyModule) andmobiledetect/mobiledetectlib(MobileEtagModule).symfony/cacheandsymfony/processallow^8.0, andray/psr-cache-moduleis raised to^1.6, the release that supports it. Thesymfony/cache5 range is dropped, since Ray^1.6requires 6.0 or later.[Unreleased]becomes[1.18.0] - 2026-10-28.Verification: see the PR comment.