Skip to content

chore(php-lol): align PHP 8.5 extension pins with latest upstream releases - #376

Merged
bdossantos merged 2 commits into
masterfrom
copilot/bump-composer-extensions
Sep 18, 2026
Merged

bdossantos merged 2 commits into
masterfrom
copilot/bump-composer-extensions

Conversation

Copilot AI commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

This updates php-lol extension version pins to current upstream releases where they were behind, while keeping Composer on the 2.10 line already used by the PHP image variants.

  • Scope: php-lol 8.5 dependency pins

    • Bumped MSGPACK_VERSION from 3.0.0 to v3.0.1
    • Bumped ZSTD_VERSION from 0.15.2 to 0.18.0
  • Build tag compatibility adjustment

    • Updated msgpack clone logic to consume the exact configured tag value (needed for v3.0.1 tag format) instead of prepending msgpack-.
  • Composer baseline

    • Composer source remains composer:2.10 (no change required).
ENV \
  MSGPACK_VERSION=v3.0.1 \
  ZSTD_VERSION=0.18.0

# before
# git clone --depth 1 --branch "msgpack-${MSGPACK_VERSION}" ...

# after
git clone --depth 1 --branch "${MSGPACK_VERSION}" \
  https://github.com/msgpack/msgpack-php /usr/src/msgpack

@bdossantos
bdossantos marked this pull request as ready for review September 18, 2026 11:56
Copilot AI lite review requested due to automatic review settings September 18, 2026 11:56
@bdossantos
bdossantos merged commit 839e08f into master Sep 18, 2026
15 of 16 checks passed
@bdossantos
bdossantos deleted the copilot/bump-composer-extensions branch September 18, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃煝 Approval recommended

The changes are straightforward version pin updates with a small git-ref adjustment, and the only feedback is minor naming consistency.

Pull request overview

Updates the php-lol PHP 8.5 Dockerfile to align extension pins with newer upstream releases, and adjusts the msgpack git clone to match the upstream tag naming scheme.

Changes:

  • Bump msgpack pin from 3.0.0 to v3.0.1 and update clone logic to use the configured ref directly.
  • Bump zstd pin from 0.15.2 to 0.18.0.
File summaries
File Description
dockerfiles/php-lol/Dockerfile.8.5 Updates extension version pins (msgpack, zstd) and adjusts msgpack clone branch selection to match the new tag format.
Review details

Suppressed comments (1)

dockerfiles/php-lol/Dockerfile.8.5:87

  • If MSGPACK_VERSION is kept as the plain version (e.g. 3.0.1), the git ref here should add the v prefix (matching the pattern used for APCU/AMQP/MEMCACHED in this Dockerfile) so the clone targets v3.0.1.
  && git clone --depth 1 --branch "${MSGPACK_VERSION}" \
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

MAILPARSE_VERSION=3.2.0 \
MEMCACHED_VERSION=3.4.0 \
MSGPACK_VERSION=3.0.0 \
MSGPACK_VERSION=v3.0.1 \
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants