Repository navigation
chore(php-lol): align PHP 8.5 extension pins with latest upstream releases - #376
Merged
Merged
Conversation
Co-authored-by: bdossantos <[email protected]>
Co-authored-by: bdossantos <[email protected]>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
The changes are straightforward version pin updates with a small git-ref adjustment, and the only feedback is minor naming consistency.
Pull request overview
Updates the php-lol PHP 8.5 Dockerfile to align extension pins with newer upstream releases, and adjusts the msgpack git clone to match the upstream tag naming scheme.
Changes:
- Bump msgpack pin from
3.0.0tov3.0.1and update clone logic to use the configured ref directly. - Bump zstd pin from
0.15.2to0.18.0.
File summaries
| File | Description |
|---|---|
| dockerfiles/php-lol/Dockerfile.8.5 | Updates extension version pins (msgpack, zstd) and adjusts msgpack clone branch selection to match the new tag format. |
Review details
Suppressed comments (1)
dockerfiles/php-lol/Dockerfile.8.5:87
- If
MSGPACK_VERSIONis kept as the plain version (e.g.3.0.1), the git ref here should add thevprefix (matching the pattern used for APCU/AMQP/MEMCACHED in this Dockerfile) so the clone targetsv3.0.1.
&& git clone --depth 1 --branch "${MSGPACK_VERSION}" \
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| MAILPARSE_VERSION=3.2.0 \ | ||
| MEMCACHED_VERSION=3.4.0 \ | ||
| MSGPACK_VERSION=3.0.0 \ | ||
| MSGPACK_VERSION=v3.0.1 \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
php-lolextension version pins to current upstream releases where they were behind, while keeping Composer on the2.10line already used by the PHP image variants.Scope: php-lol 8.5 dependency pins
MSGPACK_VERSIONfrom3.0.0tov3.0.1ZSTD_VERSIONfrom0.15.2to0.18.0Build tag compatibility adjustment
v3.0.1tag format) instead of prependingmsgpack-.Composer baseline
composer:2.10(no change required).