Repository navigation
Add php-lol PHP 8.5 image - #374
Merged
Merged
Conversation
Co-authored-by: bdossantos <[email protected]>
bdossantos
reviewed
Sep 18, 2026
Co-authored-by: bdossantos <[email protected]>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved reproducibility, security, CI validation, and root-runtime issues remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a PHP 8.5 php-lol image using the Bookworm fallback, source-built extensions, CI wiring, and documentation updates.
Changes:
- Adds the PHP 8.5.10 Dockerfile and compatible extension builds.
- Registers
php-lol85in CI. - Documents PHP 8.5 support in the README.
File summaries
| File | Review summary |
|---|---|
README.md |
Documents PHP 8.5 support. |
dockerfiles/php-lol/Dockerfile.8.5 |
Adds the PHP 8.5 image. Findings: six moderate issues (3 votes each) involving unpinned Debian packages, mutable LZ4 and Imagick sources, mutable Composer image, and root runtime; one critical issue (3 votes) involving plaintext Nginx downloads. |
docker-compose.ci.yml |
Adds the PHP 8.5 CI service. Finding: moderate (3 votes) due to nondeterministic reuse of the shared image tag during parallel builds. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 7
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| && make install \ | ||
| && ldconfig \ | ||
| && mkdir -p /usr/src/nginx \ | ||
| && curl -sSL "http://nginx.org/download/nginx-${NGINX_VERSION}.tar.gz" \ |
| build: | ||
| context: dockerfiles/php-lol | ||
| dockerfile: Dockerfile.8.5 | ||
| image: bdossantos/php-lol |
Comment on lines
+54
to
+58
| && apt-get install -y --no-install-recommends \ | ||
| acl \ | ||
| bash \ | ||
| geoip-database \ | ||
| git \ |
Comment on lines
+151
to
+156
| && curl -L -o /tmp/lz4.tar.gz https://github.com/kjdev/php-ext-lz4/archive/refs/heads/master.tar.gz \ | ||
| && tar -xzf /tmp/lz4.tar.gz -C /usr/src \ | ||
| && mv /usr/src/php-ext-lz4-master /usr/src/php-ext-lz4 \ | ||
| && pushd /usr/src/php-ext-lz4 \ | ||
| && phpize \ | ||
| && ./configure --with-lz4-includedir=/usr \ |
| tidy \ | ||
| zip \ | ||
| # Temporarily building for PHP 8.0: https://github.com/Imagick/imagick/issues/358 | ||
| && git clone --depth 1 https://github.com/Imagick/imagick /usr/src/imagick \ |
| VOLUME /etc/nginx/conf.d | ||
|
|
||
| # hadolint ignore=DL3022 | ||
| COPY --from=composer:2.10 /usr/bin/composer /usr/bin/composer |
|
|
||
| EXPOSE 80/tcp 443/tcp | ||
|
|
||
| ENTRYPOINT ["/entrypoint.sh"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a php-lol variant for PHP 8.5. Debian trixie was requested as the preferred base but is not viable:
imaprequireslibc-client-dev(UW-IMAP) andlibpcre3-dev, both removed from trixie. The image therefore uses the requested bookworm fallback.Base image
dockerfiles/php-lol/Dockerfile.8.5onphp:8.5.10-fpm-bookworm(pinned by digest), mirroring the 8.4 layout.PECL extensions built from source
Replaced
picklewith per-extension builds from pinned upstream GitHub tags (igbinary, msgpack, apcu, amqp, imap, memcached, redis, mailparse, zstd).picklebundles Composer 1.x, which fatals on PHP 8.5:Bumped for 8.5 source compatibility (older tags reference the removed
php_smart_string.h):igbinary→3.2.17RC1(only 8.5-compatible tag currently published)mailparse→3.2.0zstdbuilt with its bundledlibzstdsubmodule (--recurse-submodules, no--with-libzstd).imapis now explicitly listed indocker-php-ext-enable(pickle previously handled enablement).Bundled/core extensions in 8.5
iconv,posix,simplexml,xmlreader, andopcachefrom the install list — these are compiled in / enabled by default in the 8.5 base image, and re-installing them produces an emptymodules/and fails the build.Wiring
php-lol85service todocker-compose.ci.yml.README.md.Notes for review
IGBINARY_VERSION=3.2.17RC1is a release candidate; worth pinning to a stable 3.2.17 once available.