Repository navigation
chore(php-lol): update extension deps and composer to 2.10 - #373
Merged
Merged
Conversation
Co-authored-by: bdossantos <[email protected]>
bdossantos
marked this pull request as ready for review
September 18, 2026 09:30
bdossantos
deleted the
copilot/update-php-lol-extension-dependencies
branch
September 18, 2026 09:30
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Composer is being updated but the existing container-structure-test coverage does not validate that the composer binary exists and matches the expected 2.10.x major/minor, reducing CI confidence in this dependency bump.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the php-lol PHP 8.3 and 8.4 Dockerfiles to align PECL extension versions and the embedded Composer binary with newer stable releases, keeping both variants consistent.
Changes:
- Bumped PECL extensions:
msgpack3.0.0 → 3.0.1,mailparse3.1.8 → 3.2.0,zstd0.15.2 → 0.18.0. - Updated Composer source image used for the copied binary:
composer:2.8→composer:2.10.
File summaries
| File | Description |
|---|---|
| dockerfiles/php-lol/Dockerfile.8.4 | Updates PECL extension versions and switches Composer copy source to composer:2.10. |
| dockerfiles/php-lol/Dockerfile.8.3 | Updates PECL extension versions and switches Composer copy source to composer:2.10. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
199
to
+202
| VOLUME /etc/nginx/conf.d | ||
|
|
||
| # hadolint ignore=DL3022 | ||
| COPY --from=composer:2.8 /usr/bin/composer /usr/bin/composer | ||
| COPY --from=composer:2.10 /usr/bin/composer /usr/bin/composer |
Comment on lines
201
to
202
| COPY app.conf /etc/supervisor/conf.d/app.conf | ||
| COPY entrypoint.sh /entrypoint.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps PHP lol PECL extension dependencies and the composer base image to their latest stable versions across both PHP variants.
Changes
Dockerfile.8.3,Dockerfile.8.4):msgpack3.0.0 → 3.0.1mailparse3.1.8 → 3.2.0zstd0.15.2 → 0.18.0Dockerfile.8.3,Dockerfile.8.4):composer:2.8→composer:2.10COPY --from=composer:2.10 /usr/bin/composer /usr/bin/composerNotes
# hadolint ignore=DL3008), so there were no pinned Debian packages to bump here.