Repository navigation
chore(php-lol): decommission php-lol 8.1 and 8.2 - #372
Merged
Merged
Conversation
Co-authored-by: bdossantos <[email protected]>
Contributor
There was a problem hiding this comment.
馃煝 Approval recommended
Removed versions have no remaining active references, and CI retains the supported images.
Pull request overview
Decommissions the PHP 8.1 and 8.2 images, leaving PHP 8.3 and 8.4 supported by CI and documentation.
Changes:
- Deletes PHP 8.1 and 8.2 Dockerfiles.
- Removes their CI Compose services.
- Updates the README version list.
File summaries
| File | Description |
|---|---|
README.md |
Lists PHP versions 8.3 and 8.4. |
docker-compose.ci.yml |
Removes PHP 8.1 and 8.2 build services. |
dockerfiles/php-lol/Dockerfile.8.1 |
Deleted obsolete image definition. |
dockerfiles/php-lol/Dockerfile.8.2 |
Deleted obsolete image definition. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the end-of-life php-lol 8.1 and 8.2 images, keeping 8.3 and 8.4.
Changes
dockerfiles/php-lol/Dockerfile.8.1andDockerfile.8.2.php-lol81andphp-lol82services fromdocker-compose.ci.yml.README.mdto list(8.3, 8.4).Notes
cd.ymlauto-discovers Dockerfiles viafind, so no workflow changes are required.tests/php-lol.yamland the Makefilecontainer-structure-testtarget are version-agnostic (sharedbdossantos/php-lolimage) and remain valid.