Skip to content

32963-dissolution-email-templates#4569

Merged
mruff-aeq merged 5 commits into
bcgov:mainfrom
mruff-aeq:32963-dissolution-email-templates
Jul 15, 2026
Merged

32963-dissolution-email-templates#4569
mruff-aeq merged 5 commits into
bcgov:mainfrom
mruff-aeq:32963-dissolution-email-templates

Conversation

@mruff-aeq

@mruff-aeq mruff-aeq commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#32963

Description of changes:
this table is for me, please feel free to refer to it to denote changes

FileChange
email_processors/dissolution_notification.pyDeleted; dissolution emails now go through the shared filing_notification processor.
email_templates/DIS-PAID.html, email_templates/DIS-COMPLETED.htmlDeleted; replaced by the markdown templates below.
email_templates/dissolution.mdNew template for the completed dissolution email.
email_templates/dissolution-future.mdNew template for the future effective dissolution email sent at PAID.
email_processors/filing_notification.pyAdds the extraprovincial registrations lookup for corp dissolutions and includes the business contact and party emails in dissolution recipients.
email_processors/util.pyAdds the dissolution filing title and its attachment lists for corps, coops and firms (administrative sub-type drops the certificate).
email_processors/__init__.pyMoves get_extra_provincials here so voluntary and involuntary dissolution emails share it.
email_processors/involuntary_dissolution_stage_1_notification.pyImports get_extra_provincials from the shared module instead of defining it locally (no behavior change).
resources/business_emailer.pyRemoves the dissolution-specific dispatch branch; dissolution routes through the generic filing notification branch.
tests/unit/email_processors/test_dissolution_notification.pyDeleted along with the old processor.
tests/unit/email_processors/test_filing_notification.pyAdds dissolution coverage: headers, subjects, recipients, future effective, extraprovincial paragraph, attachments per legal type.
tests/unit/test_worker_dispatch.pyMoves dissolution into the filing_notification dispatch test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kialj876 kialj876 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mark this is looking good! I have some requested changes for you below

Comment thread queue_services/business-emailer/src/business_emailer/email_processors/util.py Outdated
@mruff-aeq mruff-aeq requested a review from kialj876 July 14, 2026 16:52

@kialj876 kialj876 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the updates!

return template_code


def get_extra_provincials(response: dict) -> list[str]:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to remove this and 'get_jurisdictions' now? I don't think it was used elsewhere

@sonarqubecloud

Copy link
Copy Markdown

@mruff-aeq mruff-aeq merged commit 2e42182 into bcgov:main Jul 15, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants