-
Notifications
You must be signed in to change notification settings - Fork 283
fix(core): honor the gitignore \# escape when loading ignore patterns #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
wangzhengzhuo05
wants to merge
1
commit into
basicmachines-co:main
from
wangzhengzhuo05:fix/bmignore-hash-escape
+54
−8
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a
.gitignorecontains\#foo, a valid pattern for the filename#foo,strip()removes the significant leading space and the new escape branch converts the remainder to#foo. Basic Memory therefore ignores/index-excludes the wrong file, whilegit check-ignore --no-indexmatches only#foo; Git's pattern format discards unescaped trailing spaces, not leading ones. Preserve leading characters when removing the line ending before recognizing the hash escape.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in replacement #1544, commit ee2f854. The parser preserves leading whitespace, decodes escaped hashes/spaces, and discards only unescaped trailing spaces. Regressions cover the reported space-plus-escaped-hash case for both loaders: 39 focused tests pass, all 22 filename expectations agree with git check-ignore, and just fast-check plus just doctor pass. Exact-head Codex gate is currently waiting on #1544.