Repository navigation
Harden file serving, authentication, and multiplayer resource limits - #140
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private static files could be reached through encoded path aliases, and a malformed WebSocket frame could terminate the server. This change closes those paths, rejects credentials changed during asynchronous verification, throttles profile passcode checks, and prevents replaced tic-tac-toe sockets from mutating resumed matches.
All room sends now enforce a 1 MiB queued-byte ceiling while preserving unsent receipts for reconnect. Static caching has an 8 MiB LRU budget with streaming above 512 KiB. Save listings avoid unused state/image payloads; one local five-slot benchmark improved 300 listings from 169.4 ms to 16.3 ms. The service worker excludes encoded API paths, honors private/no-store responses, and purges the previous cache.
Validation: 359 tests pass on Node 26.12.1 with locked ws 8.22.0; npm run check and git diff --check pass; npm audit --omit=dev reports zero vulnerabilities. Live regressions cover malformed frames on every endpoint, encoded private paths, profile throttling, stale sockets, resume, and rematch. Browser interaction checks reported no console errors, but screenshot capture timed out. Docker is unavailable locally; the existing CI container scan remains required.
The prioritized findings, benchmark context, remaining mobile-layout/query optimizations, and review limits are documented in docs/security-review-2026-10-24.md. Existing ADRs describe the strengthened boundaries. No new dependencies or migrations.