fix(sor): drop swap paths exceeding buffer wrap/unwrap capacity (erc4626 maxDeposit/maxWithdraw) - #2626
Merged
franzns merged 1 commit intoAug 12, 2026
Conversation
…626 maxDeposit/maxWithdraw)
🦋 Changeset detectedLatest commit: 403f9cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
johngrantuk
approved these changes
Aug 12, 2026
johngrantuk
left a comment
johngrantuk
left a comment
Member
There was a problem hiding this comment.
Looks like the existing maxWithdraw/Deposit filter logic is only used to filter out paths that wouldn't provide any meaningful liquidity. This PR adds a hard-enforce to reject any paths that would have previously been considered but can't actually support the size. So LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.