Repository navigation
Conversation
Three follow-ups to the change that stopped backend errors being served as misses. - A failure in the CAS existence check (the output files, stdout, stderr) was still rewrapped as `Internal`, which retry policies treat as permanent. It now keeps its own code, so a transient CAS fault is retryable like an AC one. `incomplete_entries_counter` now counts only genuine misses, not propagated errors. - Tests cover the two misses that must stay `NotFound` and were untested: an absent action-result record and an evicted Tree blob. Both fail if every lookup error is propagated. The existing get-path miss now checks for `NotFound` exactly, and a new test checks a CAS failure keeps its code (it fails against the old `Internal` wrapping). - The scheduler regression test is bounded, so a regression fails in 5 s instead of hanging, and its fake store uses its configured code. Comments no longer claim undecodable records propagate: `ac_utils` maps decode failures to `NotFound`, so they stay misses. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
completeness: keep CAS error codes, and test every miss path
Three follow-ups to the change that stopped backend errors being served as
misses.
still rewrapped as
Internal, which retry policies treat as permanent. Itnow keeps its own code, so a transient CAS fault is retryable like an AC
one.
incomplete_entries_counternow counts only genuine misses, notpropagated errors.
NotFoundand were untested: anabsent action-result record and an evicted Tree blob. Both fail if every
lookup error is propagated. The existing get-path miss now checks for
NotFoundexactly, and a new test checks a CAS failure keeps its code (itfails against the old
Internalwrapping).instead of hanging, and its fake store uses its configured code. Comments no
longer claim undecodable records propagate:
ac_utilsmaps decode failuresto
NotFound, so they stay misses.How was this verified?
The branch's own tests, run with Bazel on railgun today after the rebase onto upstream
b01417643e; CI on this PR is the first automated run.Also part of the soak branch (#73): upstream HEAD plus every pending fix, run through the railgun fleet for an hour of continuous remote builds with no errors.
Risk
A transient CAS fault during the completeness check now keeps its own code instead of
Internal, so retry policies may retry it; genuine misses still returnNotFound.incomplete_entries_counterno longer counts propagated errors.AI assistance
Written with Claude Code; b7r6 reviewed the change. Draft until the author has read the CI results.
🤖 Generated with Claude Code