Skip to content

fix(raise): activation fenêtre-seule — le raise ramenait toutes les fenêtres de l'app #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Destynova2 merged 2 commits into from
Jul 6, 2026
Merged

fix(raise): activation fenêtre-seule — le raise ramenait toutes les fenêtres de l'app #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5427f9
fix(raise): activation fenêtre-seule — le raise ramenait toutes les f…
Destynova2 Jul 6, 2026
c864746
Merge branch 'main' into fix/raise-window-only
Destynova2 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/dunst-platform/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ core-graphics = { version = "0.24", features = ["elcapitan", "highsierra"] }
foreign-types = "0.5"
objc2 = "0.6.4"
objc2-foundation = "0.3.2"
objc2-app-kit = { version = "0.3.2", features = ["NSEvent", "NSGraphicsContext"] }
objc2-app-kit = { version = "0.3.2", features = [
"NSEvent",
"NSGraphicsContext",
"NSRunningApplication",
] }

[dev-dependencies]
serde_json = { workspace = true }
Expand Down
29 changes: 20 additions & 9 deletions crates/dunst-platform/src/macos/ax_backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ pub(super) fn perform_on_element(
SemanticAction::Raise => {
let element = require_ax_element(element)?;
perform_ax_action(element, kAXRaiseAction)?;
activate_process_for_raise(target, node)
activate_process_for_raise(target)
.map_err(|err| ActionFailure::Execution(err.to_string()))
}
SemanticAction::Focus => {
Expand All @@ -289,14 +289,25 @@ pub(super) fn perform_on_element(
}
}

fn activate_process_for_raise(target: &Target, node: &SceneNode) -> Result<()> {
let window = WindowRef {
pid: target.pid,
window_id: target.window_id,
app_name: String::new(),
title: node.label.clone().unwrap_or_default(),
};
crate::borrow_target_frontmost(&window).map(|_| ())
fn activate_process_for_raise(target: &Target) -> Result<()> {
// Window-scoped activation: the kAXRaiseAction just performed made the
// target the app's key window, and activating WITHOUT
// `NSApplicationActivateAllWindows` only brings that key window forward.
// The previous osascript variant (`set frontmost of process to true`) was
// process-level: it raised every window of the app, on every display,
// over the user's foreground.
let app =
objc2_app_kit::NSRunningApplication::runningApplicationWithProcessIdentifier(target.pid)
.ok_or_else(|| {
DunstError::Execution(format!("no running application with pid {}", target.pid))
})?;
if app.activateWithOptions(objc2_app_kit::NSApplicationActivationOptions::empty()) {
Ok(())
} else {
Err(DunstError::Execution(
"AppKit refused the window-scoped activation of the target app".into(),
))
}
}

pub(super) fn require_ax_element(
Expand Down
Loading