You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(smart_scripts): document the alive state parameter of the summoned creatures target - #1300
No actionable comments were generated in the recent review.
Walkthrough
The SMART_TARGET_SUMMONED_CREATURES documentation now describes an alive-state parameter in English, Chinese, and Spanish. It lists 1 for alive creatures, 2 for dead creatures, and 0 for either state.
Changes: Summoned Creature Target Documentation
Layer / File(s)
Summary
Document the alive-state parameter docs/smart_scripts.md, docs/cn/smart_scripts.md, docs/es/smart_scripts.md
The target entry now lists the alive-state parameter and its values in all three language versions.
This is a documentation update for the alive-state option on the summoned-creature target. It does not change runtime behavior, so merging it carries no meaningful risk.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: documenting the alive-state parameter of the SMART_TARGET_SUMMONED_CREATURES target in the SmartAI docs. The raw summary shows one-line doc edits in the English, Spani…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: documenting the alive-state parameter of the SMART_TARGET_SUMMONED_CREATURES target in the SmartAI docs. The raw summary shows one-line doc edits in the English, Spanish, and Chinese smart_scripts.md files that add the alive-state values 0, 1, and 2. The title matches this change directly and is specific enough for a teammate scanning history.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 36389f93-079d-42f0-b90b-8cc9cb33e4cd
Commits
Reviewing files that changed from the base of the PR and between 13cca04 and d745507.
Files selected for processing: 3
docs/cn/smart_scripts.md
docs/es/smart_scripts.md
docs/smart_scripts.md
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Every pull request that adds, changes or removes a wiki page must follow the WIKI STANDARDS.
Read them first: https://www.azerothcore.org/wiki/wiki-standards
Description
SMART_TARGET_SUMMONED_CREATURES(204) now takes an optional alive state intarget_param2, added in fix(DB/SAI): Rework Gerenzo's Orders event azerothcore-wotlk#28462: 0 both, 1 alive, 2 deadRelated Issue
Related to azerothcore/azerothcore-wotlk#28462
Thank you for contributing to the AzerothCore wiki.
Remember that the wiki is currently available in English and Spanish.
Summary by CodeRabbit